Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17459 - Ensure help text on component create forms shows both bulk edit and substitution token instructions #17931

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

bctiemann
Copy link
Contributor

@bctiemann bctiemann commented Nov 4, 2024

Fixes: #17459

This PR does two things:

  1. Ensures that the The string <code>{module}</code> will be replaced with the position of the assigned module, if any. string is shown on the name field of modular component template create forms, in addition to the Alphanumeric ranges are supported for bulk creation string, instead of the latter overwriting the former

  2. Moves the {module} help_text logic from InterfaceCreateForm to the generic ComponentCreateForm so that it applies to all modular device components which share the same bulk creation logic

Screenshot 2024-11-04 at 3 54 53 PM

…it__ so it applies to all component types, and fix formatting
arthanson
arthanson previously approved these changes Nov 4, 2024
netbox/dcim/forms/object_create.py Outdated Show resolved Hide resolved
netbox/dcim/forms/object_create.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 6fb4760 into develop Nov 21, 2024
5 of 6 checks passed
@jeremystretch jeremystretch deleted the 17459-fix-component-help-text branch November 21, 2024 17:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Name help_text is overwritten
3 participants